Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff Marine Armour During HvH #6937

Merged
merged 15 commits into from
Aug 30, 2024
Merged

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Aug 12, 2024

About the pull request

If the Faction Clash HvH game mode is enabled, this PR will buff all Marine armours to have significantly higher bullet, bomb and/or internal_damage (internal_damage reduces the chance of internal injuries like fractures) armour values. Some values are reduced in a few cases but buffed in others however.

The explicit changes are as follows:

Medium (Includes Smartgunner, B12, IO)

  • Bullet: 30 (from 20)
  • Bomb: 20 (from 15)
  • Internal: 30 (from 20)

Light

  • Bullet: 20 (from 15)
  • Bomb: 15 (from 20)
  • Internal: 25 (from 10)

Heavy

  • Bullet: 35 (from 35)
  • Bomb: 35 (from 35)
  • Internal: 30 (from 25)

MP (Includes CO, XO, SO armours)

  • Bullet: 30 (from 20)
  • Bomb: 25 (from 20)
  • Internal: 30 (from 15)

Synthetic armour is unchanged in both game modes.

Spec armours also get buffs similar to Medium armour, B18 gets a slight boost over normal.

I have decided against effecting similar changes to Helmets, Gloves and Boots at this time.

Explain why it's good for the game

HvH is extremely lethal, especially so for Marines as their armour is not well suited to shrugging off bullets and bombs.

Whilst this change does not significantly reduce the overall time to kill of Marines in combat, it does significantly reduce the occurrence rate of a marine suffering excessive fractures and internal bleeding from being gunned down.

From testing, you should see less cases of a marine suffering three to fix fractures, and more cases of a marine suffering zero to two fractures when gunned down from full health with standard ammunition.

Death remains punishing, but it will be far less oppressive once you are revived.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: If the 'Faction Clash' human versus human game mode is enabled, all marine armours will have their defensive values significantly buffed to make marine armour far more valuable and effective in resisting permanent damage. The average Marine should experience less fractures and other permanent wounds from gunfire.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 12, 2024
@CABSHEP
Copy link

CABSHEP commented Aug 12, 2024

So Heavy armor trades speed and item slot for 10 additional bomb ressistance? Why would anyone pick Heavy Armor in HvH in that case? If you get hit by explosion, you get stunned, so you get gunned down anyway.

Especially since half of the marine force and everyone besides CLF have a lot of AP with pen higher than 30.

I think Heavy armor should be massively reworked for HvH, slowing marine down even more, but given massive bullet and internal damage armor. Maybe even make it weaker against bombs in exchange, that would be interesting.

B12, M4, IO armor and smartgunner mesh should also be buffed. Especially B12 which is 30 points purchase for being weaker than medium.

With all of that AP everyone has access to this armor buff (30) still doesn't even break M39 AP.

@TheManWithNoHands
Copy link
Contributor

TheManWithNoHands commented Aug 12, 2024

Yeah, heavy armor just gettin extra bomb is kinda silly. Its more kevlar, it should protect you from more bullets. HvH is where heavy armor should shine.

Also, you migth need to touch some more armor then just those four. B12, Grenadier spec, CO, and the service jacket have their own stats. Especially grenadier specs armor, that thing has set ALL armor values for itself.

@Zenith00000
Copy link
Contributor

To make HvH not complete ass, please just disable IB (internal bleeding), literally the worst thing about it.

@Steelpoint
Copy link
Contributor Author

@CABSHEP
I'll add values to bring the Smartgunner's armour to the standard of Medium armour. I missed that.
B12, M4 and IO's armour get buffed to the value of Medium armour, plus the unique perks those armours get remain intact in HvH. I'm not as liable to buff B12 more since its the standard issue SL armour, and its already fairly competitive now.
I agree with the Heavy Armour assessment and have returned its Bullet and Bomb values to normal.

"With all of that AP everyone has access to this armor buff (30) still doesn't even break M39 AP."
AP ammo remains quite strong in HvH but, the occurrence rate of fractures is still decreased overall thanks to these buffs, though extreme overkill can still cause a lot of injuries but that's the nature of tick rates and not dying when you should be.

@TheManWithNoHands
CO armour falls under MP armour which has been buffed to be slightly better than Medium armour.
Service jacket is not at all intended for combat use, if you really want maximum movement speed you pay the cost. It does share the same bullet defence as light armour but no bomb or internal protection, I don't think that needs to change.

@Zenith00000
We should see less IB overall thanks to this change.
I could be convinced to add quick clot as a Corpsman item but, that would be a separate PR.

@TheManWithNoHands
Copy link
Contributor

TheManWithNoHands commented Aug 13, 2024

My guy, i told you it changes the bullet armor itself.
So it wont recive a buff at all.
grafik
Although i do hope you still adress the Grenadier armor. Cause it changes so much.
grafik

@Steelpoint
Copy link
Contributor Author

@TheManWithNoHands
MP armour is buffed to 30 bullet defence, the CO already has 30 so, nothing changes as they have the intended bullet defence.
Regarding the Specialists, I'm hoping to rework that in a separate PR so all the Specs are given the (fairly strong) B18 armour.

@Steelpoint
Copy link
Contributor Author

I've also updated the Spec armours.

@Steelpoint
Copy link
Contributor Author

If an issue with balance is constrained to how strong armour piercing ammo is, perhaps a separate PR can investigate in tweaking how much AP ammo both sides get access too, making it more rare?

After doing testing I feel this is a good step for most guns.

kiVts
kiVts previously requested changes Aug 14, 2024
Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the else apocalypse

code/modules/clothing/suits/marine_armor/_marine_armor.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/marine_armor/_marine_armor.dm Outdated Show resolved Hide resolved
code/modules/clothing/suits/marine_armor/_marine_armor.dm Outdated Show resolved Hide resolved
@kiVts kiVts marked this pull request as draft August 14, 2024 15:19
@Steelpoint
Copy link
Contributor Author

I'll have to double check when I am back on my computer but I think I had a issue where if I didn't use the 'else' then the game would always put the HvH armour values in for the armour for any other game mode.

@Steelpoint Steelpoint marked this pull request as ready for review August 15, 2024 09:25
@Steelpoint
Copy link
Contributor Author

Requested changes made.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 22, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 23, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Steelpoint
Copy link
Contributor Author

Made edits to conform to recent decorator changes

@Steelpoint
Copy link
Contributor Author

Fixing merge conflict re-added something that was removed in a different PR, so I've fixed it.

@harryob harryob enabled auto-merge August 30, 2024 08:07
@harryob harryob added this pull request to the merge queue Aug 30, 2024
Merged via the queue into cmss13-devs:master with commit a0ca027 Aug 30, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Aug 30, 2024
@Steelpoint Steelpoint deleted the armourvalue branch August 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants